fix(ci): update .main.commit for non-dev mcore branches - #3214

.github/workflows/_update_dependencies.yml (1)

74-76: Consider renaming the local TARGET_BRANCH to avoid shadowing.

The TARGET_BRANCH env var here refers to inputs.mcore-branch, but there's already a TARGET_BRANCH defined at line 43 referring to inputs.target-branch. While shell scoping keeps these separate per step, the reuse is potentially confusing for future maintainers.

♻️ Suggested rename for clarity

      - name: Update submodules
        id: mlm-commit
        env:
-         TARGET_BRANCH: ${{ inputs.mcore-branch }}
+         MCORE_BRANCH: ${{ inputs.mcore-branch }}
        run: |
          pushd 3rdparty/Megatron-LM
            git fetch origin ${{ inputs.mcore-branch }}
            git checkout FETCH_HEAD
            MLM_COMMIT=$(git rev-parse HEAD)
          popd

-         if [[ "$TARGET_BRANCH" == "dev" ]]; then
+         if [[ "$MCORE_BRANCH" == "dev" ]]; then
            echo $MLM_COMMIT > .dev.commit
          else
            echo $MLM_COMMIT > .main.commit
          fi

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In @.github/workflows/_update_dependencies.yml around lines 74 - 76, The step
defines env TARGET_BRANCH = inputs.mcore-branch which shadows the earlier
TARGET_BRANCH = inputs.target-branch; rename the local variable (e.g.,
MCORE_TARGET_BRANCH or MC_TARGET_BRANCH) in this step's env and update any
downstream uses in that step to reference the new name so it's clear this is the
mcore branch and not the global TARGET_BRANCH; ensure you change occurrences of
TARGET_BRANCH inside this step (and any subsequent step-scoped references) to
the new symbol while leaving the original inputs.target-branch binding
untouched.